Harshit Mogalapalli <harshit.m.mogalapalli@xxxxxxxxxx> writes:
> Smatch reports:
> drivers/gpu/drm/pl111/pl111_drv.c:300
> pl111_amba_probe() warn: missing unwind goto?
>
> When devm_request_irq() returns non-zero value, we need to drop the
> reference for drm device and also release reserved memory which is
> done in "dev_put" label. So instead of directly returning, goto dev_put
> to fix this bug.
>
> Fixes: bed41005e617 ("drm/pl111: Initial drm/kms driver for pl111")
> Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@xxxxxxxxxx>
> ---
> This is based on static analysis, Only Compile tested.
> ---
> drivers/gpu/drm/pl111/pl111_drv.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
The patch looks correct to me.
Reviewed-by: Javier Martinez Canillas <javierm@xxxxxxxxxx>
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
