On Tuesday, July 18, 2023 11:47 PM Sam Ravnborg <sam@xxxxxxxxxxxx> wrote: > > Hi Ying Liu, Hi Sam, > > On Tue, Jul 18, 2023 at 09:00:25AM +0000, Ying Liu wrote: > > > > + if (IS_ERR(dsi->regmap)) { > > > > + ret = PTR_ERR(dsi->regmap); > > > > + DRM_DEV_ERROR(dev, "failed to get block ctrl regmap: > > > %d\n", ret); > > > > > > Could you use dev_err_probe here instead? > > > > Maybe, it's better to keep using DRM_DEV_ERROR to achieve consistent > > error log format across the driver which is implemented in > drm_dev_printk(). > > I see other DRM drivers do the same. > > All the DRM_* macros are deprecated. > New code shall use drm_*, dev_* or pr_ as appropriate. Ok, will use dev_* in v2. > > The appropriate variant here is dev_err_probe(). Ok, will use dev_err_probe() here in v2. Regards, Liu Ying > > Sam