Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> writes: > drm_fb_helper_single_fb_probe() first calls drm_fb_helper_find_sizes(), > followed by drm_fbdev_generic_helper_fb_probe(): > - The former tries to find a suitable buffer format, taking into > account limitations of the whole display pipeline, > - The latter just calls drm_mode_legacy_fb_format() again. > > Simplify this by passing the buffer format between these functions > via a new buffer format member in the drm_fb_helper_surface_size > structure. > > Signed-off-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> > --- [...] > - drm_dbg_kms(dev, "surface width(%d), height(%d) and bpp(%d)\n", > + drm_info(dev, "surface width(%d), height(%d), bpp(%d) and format(%p4cc)\n", You are promoting a debug printout here to info but that change is not mentioned in the commit message. If you think this will be useful, maybe do it as a separate patch ? The rest of the patch looks good to me though. Reviewed-by: Javier Martinez Canillas <javierm@xxxxxxxxxx> -- Best regards, Javier Martinez Canillas Core Platforms Red Hat
