Re: [PATCH v3 3/4] drm/mediatek: Add casting before assign

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 22/06/2023 10:02, Jason-JH Lin (林睿祥) wrote:
drm_plane_state *new_state,
>   dma_addr_t addr;
>   dma_addr_t hdr_addr = 0;
>   unsigned int hdr_pitch = 0;
> +int offset;

I agree with Angelo, please set offset as unsigned.

I think offset should be unsigned, but since src.x1 and src.y1 are
'int'. That means 'unsigned int' offset will be very big when src.x1 or
src.y1 is negative.
So I just use 'int' for offset here.

Ok

Reviewed-by: Alexandre Mergnat <amergnat@xxxxxxxxxxxx>

--
Regards,
Alexandre



[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux