Re: [PATCH] fbdev/hyperv_fb: Include <linux/screen_info.h>

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On 2023/7/10 15:58, Thomas Zimmermann wrote:
Include <linux/screen_info.h> to get the global screen_info state.
Fixes the following errors:

drivers/video/fbdev/hyperv_fb.c:1033:10: error: use of undeclared identifier 'screen_info'
     1033 |                 base = screen_info.lfb_base;
          |                        ^
    drivers/video/fbdev/hyperv_fb.c:1034:10: error: use of undeclared identifier 'screen_info'
     1034 |                 size = screen_info.lfb_size;
	 |                        ^
drivers/video/fbdev/hyperv_fb.c:1080:3: error: must use 'struct' tag to refer to type 'screen_info'
     1080 |                 screen_info.lfb_size = 0;
	 |                 ^
	 |                 struct
drivers/video/fbdev/hyperv_fb.c:1080:14: error: expected identifier or '('
     1080 |                 screen_info.lfb_size = 0;
	 |                            ^
    drivers/video/fbdev/hyperv_fb.c:1081:3: error: must use 'struct' tag to refer to type 'screen_info'
     1081 |                 screen_info.lfb_base = 0;
	 |                 ^
	 |                 struct
    drivers/video/fbdev/hyperv_fb.c:1081:14: error: expected identifier or '('
     1081 |                 screen_info.lfb_base = 0;
	 |                            ^
    drivers/video/fbdev/hyperv_fb.c:1082:3: error: must use 'struct' tag to refer to type 'screen_info'
     1082 |                 screen_info.orig_video_isVGA = 0;
	 |                 ^
	 |                 struct
     drivers/video/fbdev/hyperv_fb.c:1082:14: error: expected identifier or '('
     1082 |                 screen_info.orig_video_isVGA = 0;
	 |                            ^
     8 errors generated.

Reported-by: kernel test robot <lkp@xxxxxxxxx>
Closes: https://lore.kernel.org/oe-kbuild-all/202307101042.rqehuauj-lkp@xxxxxxxxx/
Fixes: 8b0d13545b09 ("efi: Do not include <linux/screen_info.h> from EFI header")
Signed-off-by: Thomas Zimmermann <tzimmermann@xxxxxxx>


Reviewed-by: Sui Jingfeng <suijingfeng@xxxxxxxxxxx>


Cc: "K. Y. Srinivasan" <kys@xxxxxxxxxxxxx> (supporter:Hyper-V/Azure CORE AND DRIVERS)
Cc: Haiyang Zhang <haiyangz@xxxxxxxxxxxxx> (supporter:Hyper-V/Azure CORE AND DRIVERS)
Cc: Wei Liu <wei.liu@xxxxxxxxxx> (supporter:Hyper-V/Azure CORE AND DRIVERS)
Cc: Dexuan Cui <decui@xxxxxxxxxxxxx> (supporter:Hyper-V/Azure CORE AND DRIVERS)
Cc: Helge Deller <deller@xxxxxx> (maintainer:FRAMEBUFFER LAYER)
Cc: Javier Martinez Canillas <javierm@xxxxxxxxxx>
Cc: Sui Jingfeng <suijingfeng@xxxxxxxxxxx>
Cc: Ard Biesheuvel <ardb@xxxxxxxxxx>
Cc: Russell King <linux@xxxxxxxxxxxxxxx>
Cc: Catalin Marinas <catalin.marinas@xxxxxxx>
Cc: Will Deacon <will@xxxxxxxxxx>
Cc: Arnd Bergmann <arnd@xxxxxxxx>
Cc: linux-efi@xxxxxxxxxxxxxxx
Cc: linux-hyperv@xxxxxxxxxxxxxxx (open list:Hyper-V/Azure CORE AND DRIVERS)
Cc: linux-fbdev@xxxxxxxxxxxxxxx (open list:FRAMEBUFFER LAYER)
Cc: dri-devel@xxxxxxxxxxxxxxxxxxxxx (open list:FRAMEBUFFER LAYER)
---
  drivers/video/fbdev/hyperv_fb.c | 1 +
  1 file changed, 1 insertion(+)

diff --git a/drivers/video/fbdev/hyperv_fb.c b/drivers/video/fbdev/hyperv_fb.c
index 1ae35ab62b29..b331452aab4f 100644
--- a/drivers/video/fbdev/hyperv_fb.c
+++ b/drivers/video/fbdev/hyperv_fb.c
@@ -48,6 +48,7 @@
  #include <linux/aperture.h>
  #include <linux/module.h>
  #include <linux/kernel.h>
+#include <linux/screen_info.h>
  #include <linux/vmalloc.h>
  #include <linux/init.h>
  #include <linux/completion.h>


Ah, I also overlook this one. :-)




[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux