On 06/07/2023 15:03, Linux regression tracking (Thorsten Leemhuis) wrote:
On 06.07.23 11:58, Jocelyn Falempe wrote:Aspeed always report the display port as "connected", because it doesn't set a .detect callback. Fix this by providing the proper detect callback for astdp and dp501. This also fixes the following regression: Since commit fae7d186403e ("drm/probe-helper: Default to 640x480 if no EDID on DP") The default resolution is now 640x480 when no monitor is connected. But Aspeed graphics is mostly used in servers, where no monitor is attached. This also affects the remote BMC resolution to 640x480, which is inconvenient, and breaks the anaconda installer. v2: Add .detect callback to the dp/dp501 connector (Jani Nikula) Signed-off-by: Jocelyn Falempe <jfalempe@xxxxxxxxxx>So if this "also fixes a regression" how about a Fixes: tag and a CC: <stable tag to ensure this is not only fixed in latest mainline, but also in all affected stable and longterm kernels?
In this case, the regression only affect one userspace program (anaconda), and the fix looks too risky to backport to all stable kernels. I've to prepare a v3, as this one breaks on hardware were there is only one Display Port connector and no VGA connector.
Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat) -- Everything you wanna know about Linux kernel regression tracking: https://linux-regtracking.leemhuis.info/about/#tldr If I did something stupid, please tell me, as explained on that page.
Best regards, -- Jocelyn
