Hi Vinod, Thanks for your comments, > -----Original Message----- > From: Vinod Koul <vkoul@xxxxxxxxxx> > Sent: 2023年6月21日 19:22 > To: Sandor Yu <sandor.yu@xxxxxxx> > Cc: andrzej.hajda@xxxxxxxxx; neil.armstrong@xxxxxxxxxx; > robert.foss@xxxxxxxxxx; Laurent.pinchart@xxxxxxxxxxxxxxxx; > jonas@xxxxxxxxx; jernej.skrabec@xxxxxxxxx; airlied@xxxxxxxxx; > daniel@xxxxxxxx; robh+dt@xxxxxxxxxx; krzysztof.kozlowski+dt@xxxxxxxxxx; > shawnguo@xxxxxxxxxx; s.hauer@xxxxxxxxxxxxxx; festevam@xxxxxxxxx; > dri-devel@xxxxxxxxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; > linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; > linux-phy@xxxxxxxxxxxxxxxxxxx; kernel@xxxxxxxxxxxxxx; dl-linux-imx > <linux-imx@xxxxxxx>; Oliver Brown <oliver.brown@xxxxxxx> > Subject: [EXT] Re: [PATCH v6 4/8] phy: Add HDMI configuration options > > Caution: This is an external email. Please take care when clicking links or > opening attachments. When in doubt, report the message using the 'Report > this email' button > > > On 15-06-23, 09:38, Sandor Yu wrote: > > Allow HDMI PHYs to be configured through the generic functions through > > a custom structure added to the generic union. > > > > The parameters added here are based on HDMI PHY implementation > > practices. The current set of parameters should cover the potential > > users. > > > > Signed-off-by: Sandor Yu <Sandor.yu@xxxxxxx> > > --- > > include/linux/phy/phy-hdmi.h | 38 > ++++++++++++++++++++++++++++++++++++ > > include/linux/phy/phy.h | 7 ++++++- > > 2 files changed, 44 insertions(+), 1 deletion(-) create mode 100644 > > include/linux/phy/phy-hdmi.h > > > > diff --git a/include/linux/phy/phy-hdmi.h > > b/include/linux/phy/phy-hdmi.h new file mode 100644 index > > 000000000000..5765aa5bc175 > > --- /dev/null > > +++ b/include/linux/phy/phy-hdmi.h > > @@ -0,0 +1,38 @@ > > +/* SPDX-License-Identifier: GPL-2.0 */ > > +/* > > + * Copyright 2022 NXP > > + */ > > + > > +#ifndef __PHY_HDMI_H_ > > +#define __PHY_HDMI_H_ > > + > > +/** > > + * Pixel Encoding as HDMI Specification > > + * RGB, YUV422, YUV444:HDMI Specification 1.4a Section 6.5 > > + * YUV420: HDMI Specification 2.a Section 7.1 */ enum > > +hdmi_phy_colorspace { > > + HDMI_PHY_COLORSPACE_RGB, /* RGB 4:4:4 */ > > + HDMI_PHY_COLORSPACE_YUV422, /* YCbCr 4:2:2 */ > > + HDMI_PHY_COLORSPACE_YUV444, /* YCbCr 4:4:4 */ > > + HDMI_PHY_COLORSPACE_YUV420, /* YCbCr 4:2:0 */ > > Better add this comments and above one as expected by kernel-doc for > enum.. OK, I will add it and it will replace by enum hdmi_colorspace in <linux/hdmi.h> in the next version. > > > + HDMI_PHY_COLORSPACE_RESERVED4, > > + HDMI_PHY_COLORSPACE_RESERVED5, > > + HDMI_PHY_COLORSPACE_RESERVED6, > > +}; > > + > > +/** > > + * struct phy_configure_opts_hdmi - HDMI configuration set > > + * @pixel_clk_rate: Pixel clock of video modes in KHz. > > + * @bpc: Maximum bits per color channel. > > + * @color_space: Colorspace in enum hdmi_phy_colorspace. > > + * > > + * This structure is used to represent the configuration state of a HDMI phy. > > + */ > > +struct phy_configure_opts_hdmi { > > + unsigned int pixel_clk_rate; > > + unsigned int bpc; > > + enum hdmi_phy_colorspace color_space; }; > > + > > +#endif /* __PHY_HDMI_H_ */ > > diff --git a/include/linux/phy/phy.h b/include/linux/phy/phy.h index > > 3a570bc59fc7..93d77d45b1d4 100644 > > --- a/include/linux/phy/phy.h > > +++ b/include/linux/phy/phy.h > > @@ -17,6 +17,7 @@ > > #include <linux/regulator/consumer.h> > > > > #include <linux/phy/phy-dp.h> > > +#include <linux/phy/phy-hdmi.h> > > #include <linux/phy/phy-lvds.h> > > #include <linux/phy/phy-mipi-dphy.h> > > > > @@ -42,7 +43,8 @@ enum phy_mode { > > PHY_MODE_MIPI_DPHY, > > PHY_MODE_SATA, > > PHY_MODE_LVDS, > > - PHY_MODE_DP > > + PHY_MODE_DP, > > + PHY_MODE_HDMI, > > }; > > > > enum phy_media { > > @@ -60,11 +62,14 @@ enum phy_media { > > * the DisplayPort protocol. > > * @lvds: Configuration set applicable for phys supporting > > * the LVDS phy mode. > > + * @hdmi: Configuration set applicable for phys supporting > > + * the HDMI phy mode. > > */ > > union phy_configure_opts { > > struct phy_configure_opts_mipi_dphy mipi_dphy; > > struct phy_configure_opts_dp dp; > > struct phy_configure_opts_lvds lvds; > > + struct phy_configure_opts_hdmi hdmi; > > }; > > > > /** > > -- > > 2.34.1 > > -- > ~Vinod B.R Sandor