Re: [PATCH] fbdev: imxfb: Convert to devm_platform_ioremap_resource()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 7/4/23 11:36, Yangtao Li wrote:
Use devm_platform_ioremap_resource() to simplify code.

Signed-off-by: Yangtao Li <frank.li@xxxxxxxx>

applied.

Thanks!
Helge

---
  drivers/video/fbdev/imxfb.c | 8 +-------
  1 file changed, 1 insertion(+), 7 deletions(-)

diff --git a/drivers/video/fbdev/imxfb.c b/drivers/video/fbdev/imxfb.c
index adf36690c342..517eb65bbaa6 100644
--- a/drivers/video/fbdev/imxfb.c
+++ b/drivers/video/fbdev/imxfb.c
@@ -868,7 +868,6 @@ static int imxfb_probe(struct platform_device *pdev)
  	struct imxfb_info *fbi;
  	struct lcd_device *lcd;
  	struct fb_info *info;
-	struct resource *res;
  	struct imx_fb_videomode *m;
  	const struct of_device_id *of_id;
  	struct device_node *display_np;
@@ -885,10 +884,6 @@ static int imxfb_probe(struct platform_device *pdev)
  	if (of_id)
  		pdev->id_entry = of_id->data;

-	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-	if (!res)
-		return -ENODEV;
-
  	info = framebuffer_alloc(sizeof(struct imxfb_info), &pdev->dev);
  	if (!info)
  		return -ENOMEM;
@@ -970,7 +965,7 @@ static int imxfb_probe(struct platform_device *pdev)
  		goto failed_getclock;
  	}

-	fbi->regs = devm_ioremap_resource(&pdev->dev, res);
+	fbi->regs = devm_platform_ioremap_resource(pdev, 0);
  	if (IS_ERR(fbi->regs)) {
  		ret = PTR_ERR(fbi->regs);
  		goto failed_ioremap;
@@ -1043,7 +1038,6 @@ static int imxfb_probe(struct platform_device *pdev)
  failed_map:
  failed_ioremap:
  failed_getclock:
-	release_mem_region(res->start, resource_size(res));
  failed_of_parse:
  	kfree(info->pseudo_palette);
  failed_init:





[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux