Daniel Thompson <daniel.thompson@xxxxxxxxxx> writes: > On Wed, Jul 05, 2023 at 03:36:46PM +0100, Måns Rullgård wrote: >> Daniel Thompson <daniel.thompson@xxxxxxxxxx> writes: >> >> > On Wed, Jul 05, 2023 at 03:24:14PM +0100, Mans Rullgard wrote: >> >> The condition for the initial power state based on the default >> >> brightness value is reversed. Fix it. >> >> >> >> Furthermore, use the actual state of the LEDs rather than the default >> >> brightness specified in the devicetree as the latter should not cause >> >> the backlight to be automatically turned on. >> >> >> >> If the backlight device is not linked to any display, set the initial >> >> power to on unconditionally. >> >> >> >> Fixes: ae232e45acf9 ("backlight: add led-backlight driver") >> >> Signed-off-by: Mans Rullgard <mans@xxxxxxxxx> >> >> --- >> >> Changes in v3: >> >> - Add comment >> > >> > This mismatches the subject line ;-) but I can live with that if Lee >> > and Jingoo can! >> >> Does it not fix it? If you think the subject is misleading, feel free >> to change it. > > The bit that goes into version control is fine! > > However without '[PATCH v3]' on the subject line for the initial patch > there is a risk this thread will get overlooked and not queued[1]. Oh, I see now I forgot to add the v3 tag. Sorry about that. -- Måns Rullgård