On Tue, Jul 04, 2023 at 12:04:01PM +0530, Pranjal Ramajor Asha Kanojiya wrote:
> > > -??????? if (user_len + trans_hdr->len > user_msg->len) {
> > > +??????? if (trans_hdr->len < sizeof(trans_hdr) ||
> > > +??????????? size_add(user_len, trans_hdr->len) > user_msg->len) {
> Since the size of characters per line is 100 now. Can we rearrange this if
> condition and have them in one line. Similarity at other places in this
> patch series.
Style is subjective so I can't say for sure that my style is better but
obviously it is. ;) Those are two separate conditions so I put them on
two lines. If it were something very related like if (x < 0 || x >= 10)
then I would have put it on one line.
regards,
dan carpenter
