On Mon, 3 Jul 2023 at 23:29, Abhinav Kumar <quic_abhinavk@xxxxxxxxxxx> wrote: > > > > On 6/19/2023 2:25 PM, Dmitry Baryshkov wrote: > > To simplify making changes to the hardware block definitions, expand > > corresponding macros. This way making all the changes are more obvious > > and visible in the source files. > > > > Tested-by: Marijn Suijten <marijn.suijten@xxxxxxxxxxxxxx> > > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx> > > --- > > the value of MERGE_3D_SM8150_MASK is 0, so to be uniform with what has > been done with some of the prev patches to drop 0 feature fields > assignment, do you want to do the same here? These patches do macro expansion (+ obvious 0-field removal). So removal of MERGE_3D_SM8150_MASK had to wait until patch 18. -- With best wishes Dmitry