Hi,
Le 02/07/2023 à 14:02, Greg Kroah-Hartman a écrit :
On Sun, Jul 02, 2023 at 10:03:24AM +0200, Raphael Gallais-Pou wrote:
Using FBTFT_REGISTER_DRIVER resolves to a NULL struct spi_device_id. This
ultimately causes the module to an early exit at probe time.
So this doesn't work at all today? Has it ever worked? What commit
does thi fix?
I tested again with only a tweak in my device-tree. The early exit in
the driver's code is caused by a missing field. So regarding this
particular driver the macro works.
It resolves to set spi_driver.id_table = NULL, which yields a warning in
__spi_register_driver(). So I guess this patch only fixes a warning.
In addition the MODULE_ALIASes can be dropped.
Why? When you say "also" or "in addition", that's a huge hint it should
be a separate patch.
I did not find any reference to those aliases in the kernel, which led
me to remove those.
If you think they are still necessary, I'll split them in an upcoming v2.
Thanks for your insights,
Raphaël
thanks,
greg k-h
