Re: [PATCH] arch/sparc: Add module license and description for fbdev helpers

[Thomas Zimmermann <tzimmermann@xxxxxxx>]

Hi Helge

Am 30.06.23 um 11:43 schrieb Helge Deller:
> On 6/27/23 16:58, Thomas Zimmermann wrote:
> > Add MODULE_LICENSE() and MODULE_DESCRIPTION() for fbdev helpers
> > on sparc. Fixes the following error:
> >
> > ERROR: modpost: missing MODULE_LICENSE() in arch/sparc/video/fbdev.o
> >
> > Reported-by: Guenter Roeck <linux@xxxxxxxxxxxx>
> > Closes: 
> > https://lore.kernel.org/dri-devel/c525adc9-6623-4660-8718-e0c9311563b8@xxxxxxxxxxxx/
> > Suggested-by: Arnd Bergmann <arnd@xxxxxxxx>
> > Fixes: 4eec0b3048fc ("arch/sparc: Implement fb_is_primary_device() in 
> > source file")
> > Cc: "David S. Miller" <davem@xxxxxxxxxxxxx>
> > Cc: Helge Deller <deller@xxxxxx>
> > Cc: Sam Ravnborg <sam@xxxxxxxxxxxx>
> > Cc: sparclinux@xxxxxxxxxxxxxxx
> > Signed-off-by: Thomas Zimmermann <tzimmermann@xxxxxxx>
> > ---
> >   arch/sparc/video/fbdev.c | 3 +++
> >   1 file changed, 3 insertions(+)
>
> I've queued it up in the fbdev git tree but will drop it anytime
> if someone prefers to take this patch through another tree....

It's in drm-misc-next-fixes already.

Best regards
Thomas

> Thanks!
> Helge
>
>
> > diff --git a/arch/sparc/video/fbdev.c b/arch/sparc/video/fbdev.c
> > index 25837f128132d..bff66dd1909a4 100644
> > --- a/arch/sparc/video/fbdev.c
> > +++ b/arch/sparc/video/fbdev.c
> > @@ -21,3 +21,6 @@ int fb_is_primary_device(struct fb_info *info)
> >       return 0;
> >   }
> >   EXPORT_SYMBOL(fb_is_primary_device);
> > +
> > +MODULE_DESCRIPTION("Sparc fbdev helpers");
> > +MODULE_LICENSE("GPL");

--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)

Attachment: OpenPGP_signature
Description: OpenPGP digital signature