On 2023/6/29 14:37, Christian König wrote: > This has already been fixed with: > > commit 2ce977df10c179138e2723b25c2d2c055a3e3cc6 > Author: Ma Jun <Jun.Ma2@xxxxxxx> > Date: Wed May 31 13:30:51 2023 +0800 > > drm/ttm: Remove redundant code in ttm_tt_init_fields > > Remove redundant assignment code for ttm->caching as it's overwritten > just a few lines later. > > v2: > - Update the commit message. > > Signed-off-by: Ma Jun <Jun.Ma2@xxxxxxx> > Reviewed-by: Guchun Chen <guchun.chen@xxxxxxx> > Reviewed-by: Christian König <christian.koenig@xxxxxxx> > Signed-off-by: Christian König <christian.koenig@xxxxxxx> > Link: https://patchwork.freedesktop.org/patch/msgid/20230531053051.3453509-1-Jun.Ma2@xxxxxxx > > > Regards, > Christian. > > Am 25.06.23 um 04:45 schrieb Feng Jiang: >> The parameter 'caching' has already been assigned to >> 'ttm->caching', so 'ttm_cached' is redundant. >> >> Fixes: 1b4ea4c5980f ("drm/ttm: set the tt caching state at creation time") >> Signed-off-by: Feng Jiang <jiangfeng@xxxxxxxxxx> >> --- >> drivers/gpu/drm/ttm/ttm_tt.c | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/drivers/gpu/drm/ttm/ttm_tt.c b/drivers/gpu/drm/ttm/ttm_tt.c >> index ab725d9d14a6..1ce4b36ab33b 100644 >> --- a/drivers/gpu/drm/ttm/ttm_tt.c >> +++ b/drivers/gpu/drm/ttm/ttm_tt.c >> @@ -137,7 +137,6 @@ static void ttm_tt_init_fields(struct ttm_tt *ttm, >> unsigned long extra_pages) >> { >> ttm->num_pages = (PAGE_ALIGN(bo->base.size) >> PAGE_SHIFT) + extra_pages; >> - ttm->caching = ttm_cached; >> ttm->page_flags = page_flags; >> ttm->dma_address = NULL; >> ttm->swap_storage = NULL; > Sorry, I will check before sending next time, thanks! -- Best regards, Feng
