On 2023-06-24 11:12:52, Krzysztof Kozlowski wrote: > On 24/06/2023 02:41, Marijn Suijten wrote: > > SM6125 is identical to SM6375 except that while downstream also defines > > a throttle clock, its presence results in timeouts whereas SM6375 > > requires it to not observe any timeouts. > > Then it should not be allowed, so you need either "else:" block or > another "if: properties: compatible:" to disallow it. Because in current > patch it would be allowed. That means this binding is wrong/incomplete for all other SoCs then. clock(-name)s has 6 items, and sets `minItems: 6`. Only for sm6375-dpu does it set `minItems: 7`, but an else case is missing. Shall I send a Fixes: ed41005f5b7c ("dt-bindings: display/msm: sc7180-dpu: Describe SM6350 and SM6375") for that, and should maxItems: 6 be the default under clock(-name)s or in an else:? - Marijn