On 2023-06-17 03:48:33, Dmitry Baryshkov wrote: > On 17/06/2023 01:12, Marijn Suijten wrote: > > On 2023-06-16 13:03:15, Dmitry Baryshkov wrote: > >> To simplify making changes to the hardware block definitions, expand > >> corresponding macros. This way making all the changes are more obvious > >> and visible in the source files. > >> > >> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx> > > > > Looks good but I am not sure how much it is worth to review this (versus > > checking your script and rerunning it to see if I get the same results), > > considering that there are quite some conflicts with your interrupt > > rework. In what order to you intend to land that? > > As I wrote, this series goes in first. Initially I designed them the > other way, but intr rework depends on DPU revision changes, while this > one doesn't have such dependencies. Thanks, I'll drop the intr rework from my local "-next" then. Have been collecting and testing almost all patches that way thus far, but it's becoming hairy with so many dependencies. Will pick it up again once a v2 lands. Is any review still needed on the current v1 (or was it RFC)? - Marijn