Hi Geert, Thank you for the patch. On Thu, Jun 22, 2023 at 11:28:48AM +0200, Geert Uytterhoeven wrote: > When configurating a CHn Source Image Format Register (LDBBSIFR), one > should use the corresponding LDBBSIFR_RPKF_* definition for overlay > planes, not the DDFR_PKF_* definition for the primary plane. > > Fortunately both definitions resolve to the same value, so this bug did > not cause any harm. > > Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> > --- > drivers/video/fbdev/sh_mobile_lcdcfb.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/video/fbdev/sh_mobile_lcdcfb.c b/drivers/video/fbdev/sh_mobile_lcdcfb.c > index 093f035d12463a80..0adb2ba965e7120d 100644 > --- a/drivers/video/fbdev/sh_mobile_lcdcfb.c > +++ b/drivers/video/fbdev/sh_mobile_lcdcfb.c > @@ -824,7 +824,7 @@ static void sh_mobile_lcdc_overlay_setup(struct sh_mobile_lcdc_overlay *ovl) > format |= LDBBSIFR_AL_1 | LDBBSIFR_RY | LDBBSIFR_RPKF_RGB24; > break; > case V4L2_PIX_FMT_BGR32: > - format |= LDBBSIFR_AL_PK | LDBBSIFR_RY | LDDFR_PKF_ARGB32; > + format |= LDBBSIFR_AL_PK | LDBBSIFR_RY | LDBBSIFR_RPKF_ARGB32; Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@xxxxxxxxxxxxxxxx> > break; > case V4L2_PIX_FMT_NV12: > case V4L2_PIX_FMT_NV21: -- Regards, Laurent Pinchart
