Hello, miquel.raynal@xxxxxxxxxxx wrote on Mon, 19 Jun 2023 09:43:48 +0200: > From: Thomas Weber <thomas.weber@xxxxxxxxxxxxx> > > Add support for the Mitsubishi AA084XE01 panel which is an 8.4 inch XGA > TFT-LCD module for industrial use. > > Link: https://www.mouser.fr/datasheet/2/274/aa084xe01_e-364171.pdf > Signed-off-by: Thomas Weber <thomas.weber@xxxxxxxxxxxxx> > Signed-off-by: Miquel Raynal <miquel.raynal@xxxxxxxxxxx> > --- > > Changes in v2: > * Lowered the clock to match the typical 65MHz frequency. > * Added the connector type and the missing bus flags. > * Collected an A-by tag. > > drivers/gpu/drm/panel/panel-simple.c | 29 ++++++++++++++++++++++++++++ > 1 file changed, 29 insertions(+) > > diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c > index 8a3b685c2fcc..963f3223c985 100644 > --- a/drivers/gpu/drm/panel/panel-simple.c > +++ b/drivers/gpu/drm/panel/panel-simple.c > @@ -2670,6 +2670,32 @@ static const struct panel_desc mitsubishi_aa070mc01 = { > .bus_flags = DRM_BUS_FLAG_DE_HIGH, > }; > > +static const struct drm_display_mode mitsubishi_aa084xe01_mode = { > + .clock = 56234, > + .hdisplay = 1024, > + .hsync_start = 1024 + 24, > + .hsync_end = 1024 + 24 + 63, > + .htotal = 1024 + 24 + 63 + 1, > + .vdisplay = 768, > + .vsync_start = 768 + 3, > + .vsync_end = 768 + 3 + 6, > + .vtotal = 768 + 3 + 6 + 1, > + .flags = DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_PVSYNC, > +}; > + > +static const struct panel_desc mitsubishi_aa084xe01 = { > + .modes = &mitsubishi_aa084xe01_mode, > + .num_modes = 1, > + .bpc = 8, > + .size = { > + .width = 1024, > + .height = 768, > + }, > + .bus_format = MEDIA_BUS_FMT_RGB565_1X16, > + .connector_type = DRM_MODE_CONNECTOR_LVDS, I've got confused, the connector is a DPI connector. On my board there are two RGB-LVDS and LVDS-RGB connectors, but this is not relevant here. I'll send an update using the right connector type. > + .bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_SAMPLE_NEGEDGE, > +}; > + > static const struct display_timing multi_inno_mi0700s4t_6_timing = { > .pixelclock = { 29000000, 33000000, 38000000 }, > .hactive = { 800, 800, 800 }, > @@ -4158,6 +4184,9 @@ static const struct of_device_id platform_of_match[] = { > }, { > .compatible = "mitsubishi,aa070mc01-ca1", > .data = &mitsubishi_aa070mc01, > + }, { > + .compatible = "mitsubishi,aa084xe01", > + .data = &mitsubishi_aa084xe01, > }, { > .compatible = "multi-inno,mi0700s4t-6", > .data = &multi_inno_mi0700s4t_6, Thanks, Miquèl
