Re: [PATCH v10 07/11] drm/etnaviv: Add support for the dma coherent device

[Sui Jingfeng <suijingfeng@xxxxxxxxxxx>]

On 2023/6/21 18:00, Lucas Stach wrote:
> >   	/* list of GEM objects: */
> >   	struct mutex gem_lock;
> >   	struct list_head gem_list;
> > diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gem.c b/drivers/gpu/drm/etnaviv/etnaviv_gem.c
> > index b5f73502e3dd..39bdc3774f2d 100644
> > --- a/drivers/gpu/drm/etnaviv/etnaviv_gem.c
> > +++ b/drivers/gpu/drm/etnaviv/etnaviv_gem.c
> > @@ -343,6 +343,7 @@ void *etnaviv_gem_vmap(struct drm_gem_object *obj)
> >   static void *etnaviv_gem_vmap_impl(struct etnaviv_gem_object *obj)
> >   {
> >   	struct page **pages;
> > +	pgprot_t prot;
> >   
> >   	lockdep_assert_held(&obj->lock);
> >   
> > @@ -350,8 +351,19 @@ static void *etnaviv_gem_vmap_impl(struct etnaviv_gem_object *obj)
> >   	if (IS_ERR(pages))
> >   		return NULL;
> >   
> > -	return vmap(pages, obj->base.size >> PAGE_SHIFT,
> > -			VM_MAP, pgprot_writecombine(PAGE_KERNEL));
> > +	switch (obj->flags) {
> switch (obj->flags & ETNA_BO_CACHE_MASK)
This is certainly OK, acceptable!

--
Jingfeng