[AMD Official Use Only - General] > -----Original Message----- > From: Johannes Berg <johannes@xxxxxxxxxxxxxxxx> > Sent: Monday, June 19, 2023 4:24 PM > To: Limonciello, Mario <Mario.Limonciello@xxxxxxx>; Quan, Evan > <Evan.Quan@xxxxxxx> > Cc: linux-kernel@xxxxxxxxxxxxxxx; linux-acpi@xxxxxxxxxxxxxxx; amd- > gfx@xxxxxxxxxxxxxxxxxxxxx; dri-devel@xxxxxxxxxxxxxxxxxxxxx; linux- > wireless@xxxxxxxxxxxxxxx; rafael@xxxxxxxxxx; lenb@xxxxxxxxxx; Deucher, > Alexander <Alexander.Deucher@xxxxxxx>; Koenig, Christian > <Christian.Koenig@xxxxxxx>; Pan, Xinhui <Xinhui.Pan@xxxxxxx>; > airlied@xxxxxxxxx; daniel@xxxxxxxx; kvalo@xxxxxxxxxx; nbd@xxxxxxxx; > lorenzo@xxxxxxxxxx; ryder.lee@xxxxxxxxxxxx; shayne.chen@xxxxxxxxxxxx; > sean.wang@xxxxxxxxxxxx; matthias.bgg@xxxxxxxxx; > angelogioacchino.delregno@xxxxxxxxxxxxx; Lazar, Lijo <Lijo.Lazar@xxxxxxx> > Subject: Re: [PATCH V3 2/7] wifi: mac80211: Add support for ACPI WBRF > > On Sun, 2023-06-18 at 21:17 -0500, Mario Limonciello wrote: > > > > > --- a/include/net/cfg80211.h > > > +++ b/include/net/cfg80211.h > > > @@ -920,6 +920,14 @@ const struct cfg80211_chan_def * > > > cfg80211_chandef_compatible(const struct cfg80211_chan_def > *chandef1, > > > const struct cfg80211_chan_def *chandef2); > > > > > > +/** > > > + * nl80211_chan_width_to_mhz - get the channel width in Mhz > > > + * @chan_width: the channel width from &enum nl80211_chan_width > > > + * Return: channel width in Mhz if the chan_width from &enum > > > +nl80211_chan_width > > > + * is valid. -1 otherwise. > > > + */ > > > +int nl80211_chan_width_to_mhz(enum nl80211_chan_width > chan_width); > > > + > > > > It's up to mac80211 maintainers, but I would think that the changes to > > change nl80211_chan_width_to_mhz from static to exported should be > > separate from the patch to introduced WBRF support in the series. > > Yeah, that'd be nice :) OK, I will move that into a new patch. > > > > > +#define KHZ_TO_HZ(freq) ((freq) * 1000ULL) > > Together with MHZ_TO_KHZ() for example :) Sure. Evan > > johannes