Re: [PATCH] drm/bridge_connector: use drm_kms_helper_connector_hotplug_event()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Simon,
On Tue, Jun 20, 2023 at 05:55:09PM +0000, Simon Ser wrote:
> This adds more information to the hotplug uevent and lets user-space
> know that it's about a particular connector only.

Will this change have impact on user space?
They will start to see CONNECTOR=n where they did not occur before.
Asking as I have not really worked with the hotplug stuff.

The code change looks fine - no comment there.
And if there are no user space worries then:
Reviewed-by: Sam Ravnborg <sam@xxxxxxxxxxxx>

	Sam

> 
> Signed-off-by: Simon Ser <contact@xxxxxxxxxxx>
> Cc: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>
> Cc: Paul Cercueil <paul@xxxxxxxxxxxxxxx>
> Cc: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
> Cc: Sam Ravnborg <sam@xxxxxxxxxxxx>
> ---
>  drivers/gpu/drm/drm_bridge_connector.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/drm_bridge_connector.c b/drivers/gpu/drm/drm_bridge_connector.c
> index 19ae4a177ac3..fc6f16e14f36 100644
> --- a/drivers/gpu/drm/drm_bridge_connector.c
> +++ b/drivers/gpu/drm/drm_bridge_connector.c
> @@ -125,7 +125,7 @@ static void drm_bridge_connector_hpd_cb(void *cb_data,
>  
>  	drm_bridge_connector_hpd_notify(connector, status);
>  
> -	drm_kms_helper_hotplug_event(dev);
> +	drm_kms_helper_connector_hotplug_event(connector);
>  }
>  
>  static void drm_bridge_connector_enable_hpd(struct drm_connector *connector)
> -- 
> 2.41.0
> 



[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux