On Mon, Jun 19, 2023 at 6:12 PM Sui Jingfeng <suijingfeng@xxxxxxxxxxx> wrote: > > Hi. > > On 2023/6/19 17:18, Huacai Chen wrote: > >> + > >> +enum loongson_chip_id { > >> + CHIP_LS7A1000 = 0, > >> + CHIP_LS7A2000 = 1, > >> + CHIP_LS_LAST, > > CHIP_LAST or CHIP_LOONGSON_LAST? > > > This is intended, CHIP_LAST is already defined by other drivers. > > It will not cause redefinition, but it deny my VIM text editor jump to > > the right place on one shot. Then use CHIP_LOONGSON_LAST please. Huacai > > -- > Jingfeng >