Hi Miquel, On Fri, Jun 16, 2023 at 06:45:24PM +0200, Miquel Raynal wrote: > From: Thomas Weber <thomas.weber@xxxxxxxxxxxxx> > > Add support for the Mitsubishi AA084XE01 panel which is an 8.4 inch XGA > TFT-LCD module for industrial use. > > Link: https://www.mouser.fr/datasheet/2/274/aa084xe01_e-364171.pdf > Signed-off-by: Thomas Weber <thomas.weber@xxxxxxxxxxxxx> > Signed-off-by: Miquel Raynal <miquel.raynal@xxxxxxxxxxx> > --- > drivers/gpu/drm/panel/panel-simple.c | 27 +++++++++++++++++++++++++++ > 1 file changed, 27 insertions(+) > > diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c > index 8a3b685c2fcc..f79c9f9124a0 100644 > --- a/drivers/gpu/drm/panel/panel-simple.c > +++ b/drivers/gpu/drm/panel/panel-simple.c > @@ -2670,6 +2670,30 @@ static const struct panel_desc mitsubishi_aa070mc01 = { > .bus_flags = DRM_BUS_FLAG_DE_HIGH, > }; > > +static const struct drm_display_mode mitsubishi_aa084xe01_mode = { > + .clock = 80000, > + .hdisplay = 1024, > + .hsync_start = 1024 + 24, > + .hsync_end = 1024 + 24 + 63, > + .htotal = 1024 + 24 + 63 + 1, > + .vdisplay = 768, > + .vsync_start = 768 + 3, > + .vsync_end = 768 + 3 + 6, > + .vtotal = 768 + 3 + 6 + 1, > + .flags = DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_PVSYNC, > +}; > + > +static const struct panel_desc mitsubishi_aa084xe01 = { > + .modes = &mitsubishi_aa084xe01_mode, > + .num_modes = 1, > + .bpc = 8, > + .size = { > + .width = 1024, > + .height = 768, > + }, > + .bus_format = MEDIA_BUS_FMT_RGB565_1X16, > +}; The .connector_type must be set. Also consider if .bus_flags needs to be specified. Sam
