Re: [PATCH v2 4/4] drm/mediatek: Fix dereference before null check

[Jason-JH Lin (林睿祥) <Jason-JH.Lin@xxxxxxxxxxxx>]

Hi Angelo,

On Wed, 2023-06-14 at 10:43 +0200, AngeloGioacchino Del Regno wrote:

External email : Please do not click links or open attachments until you have verified the sender or the content.

Il 13/06/23 13:32, Jason-JH.Lin ha scritto:

> Null-checking state suggests that it may be null, but it has already

> been dereferenced on drm_atomic_get_new_plane_state(state, plane).

> 

> The parameter state will never be NULL currently, so just remove the

> state is NULL flow in this function.

> 

> Signed-off-by: Jason-JH.Lin <jason-jh.lin@xxxxxxxxxxxx>

> Fixes: 5ddb0bd4ddc3 ("drm/atomic: Pass the full state to planes async atomic check and update")

Fixes before S-o-b...

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxx>

Thanks, I'll swap it at the next version.

Regards,

Jason-JH.Lin

************* MEDIATEK Confidentiality Notice ********************
The information contained in this e-mail message (including any 
attachments) may be confidential, proprietary, privileged, or otherwise
exempt from disclosure under applicable laws. It is intended to be 
conveyed only to the designated recipient(s). Any use, dissemination, 
distribution, printing, retaining or copying of this e-mail (including its 
attachments) by unintended recipient(s) is strictly prohibited and may 
be unlawful. If you are not an intended recipient of this e-mail, or believe 
that you have received this e-mail in error, please notify the sender 
immediately (by replying to this e-mail), delete any and all copies of 
this e-mail (including any attachments) from your system, and do not
disclose the content of this e-mail to any other person. Thank you!