Re: [PATCH] drm/amdgpu: remove unneeded variable

[Alex Deucher <alexdeucher@xxxxxxxxx>]

On Wed, Jun 14, 2023 at 3:20 AM <baomingtong001@xxxxxxxxxx> wrote:
>
> fix the following coccicheck warning:
>
> drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu7_powertune.c:1156:5-11:
> Unneeded variable: "result".
>

This variable is used and the code fails to compile with it removed.

Alex

> Signed-off-by: Mingtong Bao <baomingtong001@xxxxxxxxxx>
> ---
>   drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu7_powertune.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu7_powertune.c
> b/drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu7_powertune.c
> index 21be23ec3c79..36aa7657c66d 100644
> --- a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu7_powertune.c
> +++ b/drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu7_powertune.c
> @@ -1153,7 +1153,6 @@ int smu7_enable_power_containment(struct pp_hwmgr
> *hwmgr)
>       struct phm_ppt_v1_information *table_info =
>               (struct phm_ppt_v1_information *)(hwmgr->pptable);
>       int smc_result;
> -    int result = 0;
>       struct phm_cac_tdp_table *cac_table;
>
>       data->power_containment_features = 0;
> @@ -1191,7 +1190,7 @@ int smu7_enable_power_containment(struct pp_hwmgr
> *hwmgr)
>               }
>           }
>       }
> -    return result;
> +    return 0;
>   }
>
>   int smu7_disable_power_containment(struct pp_hwmgr *hwmgr)