Hi Am 15.06.23 um 16:50 schrieb Simon Ser:
On Thursday, June 15th, 2023 at 11:31, Thomas Zimmermann <tzimmermann@xxxxxxx> wrote:Set drm_gem_prime_handle_to_fd() and drm_gem_prime_fd_to_handle() for all DRM drivers. Even drivers that do not support PRIME import or export of dma-bufs can now import their own buffer objects. This is required by some userspace, such as wlroots-based compositors, to share buffers among processes. The only driver that does not use the drm_gem_prime_*() helpers is vmwgfx. Once it has been converted, the callbacks in struct drm_driver can be removed. Simon Ser implemented the feature for drivers based on GEM VRAM helpers in [1]. This patchset generalizes the code for all drivers that do not otherwise support PRIME. Tested by running sway with gma500 hardware.Very nice! Thanks a lot for doing this! Just one minor comment about docs. I think there are also some remaining references to drm_gem_prime_handle_to_fd() and drm_gem_prime_fd_to_handle() in the drm_prime.c overview. These become stale since this series unexports these functions.
I'll address the documentation issue.
With that fixed: Reviewed-by: Simon Ser <contact@xxxxxxxxxxx>
Thanks a lot. Best regards Thomas -- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Frankenstrasse 146, 90461 Nuernberg, Germany GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman HRB 36809 (AG Nuernberg)
Attachment:
OpenPGP_signature
Description: OpenPGP digital signature
