Re: [PATCH 1/2] drm/msm/dsi: dsi_host: drop unused clocks

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2023-06-15 01:44:01, Dmitry Baryshkov wrote:
> Several source clocks are not used anymore, so stop handling them.
> 
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>

Indeed, we were not using these parent clocks for anything.

Reviewed-by: Marijn Suijten <marijn.suijten@xxxxxxxxxxxxxx>

> ---
>  drivers/gpu/drm/msm/dsi/dsi_host.c | 33 ------------------------------
>  1 file changed, 33 deletions(-)
> 
> diff --git a/drivers/gpu/drm/msm/dsi/dsi_host.c b/drivers/gpu/drm/msm/dsi/dsi_host.c
> index fb1d3a25765f..eaee621aa6c8 100644
> --- a/drivers/gpu/drm/msm/dsi/dsi_host.c
> +++ b/drivers/gpu/drm/msm/dsi/dsi_host.c
> @@ -118,8 +118,6 @@ struct msm_dsi_host {
>  	struct clk *byte_clk;
>  	struct clk *esc_clk;
>  	struct clk *pixel_clk;
> -	struct clk *byte_clk_src;
> -	struct clk *pixel_clk_src;
>  	struct clk *byte_intf_clk;
>  
>  	unsigned long byte_clk_rate;
> @@ -129,8 +127,6 @@ struct msm_dsi_host {
>  
>  	/* DSI v2 specific clocks */
>  	struct clk *src_clk;
> -	struct clk *esc_clk_src;
> -	struct clk *dsi_clk_src;
>  
>  	unsigned long src_clk_rate;
>  
> @@ -267,21 +263,6 @@ int dsi_clk_init_v2(struct msm_dsi_host *msm_host)
>  		return ret;
>  	}
>  
> -	msm_host->esc_clk_src = clk_get_parent(msm_host->esc_clk);
> -	if (!msm_host->esc_clk_src) {
> -		ret = -ENODEV;
> -		pr_err("%s: can't get esc clock parent. ret=%d\n",
> -			__func__, ret);
> -		return ret;
> -	}
> -
> -	msm_host->dsi_clk_src = clk_get_parent(msm_host->src_clk);
> -	if (!msm_host->dsi_clk_src) {
> -		ret = -ENODEV;
> -		pr_err("%s: can't get src clock parent. ret=%d\n",
> -			__func__, ret);
> -	}
> -
>  	return ret;
>  }
>  
> @@ -346,20 +327,6 @@ static int dsi_clk_init(struct msm_dsi_host *msm_host)
>  		goto exit;
>  	}
>  
> -	msm_host->byte_clk_src = clk_get_parent(msm_host->byte_clk);
> -	if (IS_ERR(msm_host->byte_clk_src)) {
> -		ret = PTR_ERR(msm_host->byte_clk_src);
> -		pr_err("%s: can't find byte_clk clock. ret=%d\n", __func__, ret);
> -		goto exit;
> -	}
> -
> -	msm_host->pixel_clk_src = clk_get_parent(msm_host->pixel_clk);
> -	if (IS_ERR(msm_host->pixel_clk_src)) {
> -		ret = PTR_ERR(msm_host->pixel_clk_src);
> -		pr_err("%s: can't find pixel_clk clock. ret=%d\n", __func__, ret);
> -		goto exit;
> -	}
> -
>  	if (cfg_hnd->ops->clk_init_ver)
>  		ret = cfg_hnd->ops->clk_init_ver(msm_host);
>  exit:
> -- 
> 2.39.2
> 



[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux