Hi Krzysztof, On Tue, 2023-06-13 at 20:24 +0200, Krzysztof Kozlowski wrote: > On 13/06/2023 16:47, Sarah Walker wrote: > > Add the device tree binding documentation for the Series AXE GPU used in > > TI AM62 SoCs. > > > > I don't see improvements. That's a NAK :( > > This is a friendly reminder during the review process. > > It seems my previous comments were not fully addressed. Maybe my > feedback got lost between the quotes, maybe you just forgot to apply it. > Please go back to the previous discussion and either implement all > requested changes or keep discussing them. > Apologies for not including a change log for this patch and for not highlighting that we'd made changes in this area in the covering letter as well. This was an oversight on our part. The change log for this patch is as follows: * Added commit message description * Dropped quotes from $id and $schema * Dropped reg minItems * Dropped _clk suffixes from clock-names * Dropped operating-points-v2 property * Added missing additionalProperties:false * Removed stray blank line at end of file We'll be sure to include this information going forwards. We've also run 'make dt_binding_check' and there are no reported issues that we can see. As far as I'm aware, this should cover all your feedback on the previous version of the patch. Of course, we may have missed something or unintentionally introduced more issues. We'd really appreciate if you can highlight anything else that needs fixing and we'll make sure we address it in the next iteration and/or respond to individual points where necessary. Thank you for your feedback so far. Best regards, Frank > Thank you. > > Best regards, > Krzysztof >
