>-----Original Message----- >From: dri-devel <dri-devel-bounces@xxxxxxxxxxxxxxxxxxxxx> On Behalf Of >Thomas Zimmermann >Sent: Monday, June 12, 2023 10:08 AM >To: daniel@xxxxxxxx; javierm@xxxxxxxxxx; sam@xxxxxxxxxxxx; >deller@xxxxxx; geert+renesas@xxxxxxxxx; lee@xxxxxxxxxx; >daniel.thompson@xxxxxxxxxx; jingoohan1@xxxxxxxxx; >dan.carpenter@xxxxxxxxxx; Ruhl, Michael J <michael.j.ruhl@xxxxxxxxx> >Cc: linux-fbdev@xxxxxxxxxxxxxxx; Laurent Pinchart ><laurent.pinchart+renesas@xxxxxxxxxxxxxxxx>; linux-sh@xxxxxxxxxxxxxxx; >linux-staging@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; dri- >devel@xxxxxxxxxxxxxxxxxxxxx; stable@xxxxxxxxxxxxxxx; Thomas Zimmermann ><tzimmermann@xxxxxxx>; linux-omap@xxxxxxxxxxxxxxx >Subject: [PATCH v2 01/38] backlight/bd6107: Compare against struct >fb_info.device > >Struct bd6107_platform_data refers to a platform device within >the Linux device hierarchy. The test in bd6107_backlight_check_fb() >compares it against the fbdev device in struct fb_info.dev, which >is different. Fix the test by comparing to struct fb_info.device. > >Fixes a bug in the backlight driver and prepares fbdev for making >struct fb_info.dev optional. > >v2: > * move renames into separate patch (Javier, Sam, Michael) > >Fixes: 67b43e590415 ("backlight: Add ROHM BD6107 backlight driver") >Signed-off-by: Thomas Zimmermann <tzimmermann@xxxxxxx> >Cc: Laurent Pinchart <laurent.pinchart+renesas@xxxxxxxxxxxxxxxx> >Cc: Lee Jones <lee@xxxxxxxxxx> >Cc: Daniel Thompson <daniel.thompson@xxxxxxxxxx> >Cc: Jingoo Han <jingoohan1@xxxxxxxxx> >Cc: dri-devel@xxxxxxxxxxxxxxxxxxxxx >Cc: <stable@xxxxxxxxxxxxxxx> # v3.12+ >Reviewed-by: Javier Martinez Canillas <javierm@xxxxxxxxxx> >--- > drivers/video/backlight/bd6107.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/drivers/video/backlight/bd6107.c >b/drivers/video/backlight/bd6107.c >index f4db6c064635b..e3410444ea235 100644 >--- a/drivers/video/backlight/bd6107.c >+++ b/drivers/video/backlight/bd6107.c >@@ -104,7 +104,7 @@ static int bd6107_backlight_check_fb(struct >backlight_device *backlight, > { > struct bd6107 *bd = bl_get_data(backlight); > >- return bd->pdata->fbdev == NULL || bd->pdata->fbdev == info->dev; >+ return bd->pdata->fbdev == NULL || bd->pdata->fbdev == info->device; Thomas, Looking at the fb.h file I see: struct device *device; /* This is the parent */ struct device *dev; /* This is this fb device */ Is this documentation "correct"? If so, how does that match what you are doing here? Thanks, M > } > > static const struct backlight_ops bd6107_backlight_ops = { >-- >2.41.0