Re: [RESEND PATCH v2 2/6] ARM: dts: stm32: add pin map for LTDC on stm32f7

[Alexandre TORGUE <alexandre.torgue@xxxxxxxxxxx>]

hi Dario

On 6/9/23 08:21, Dario Binacchi wrote:
> Hi Alexandre,
>
> On Thu, Jun 8, 2023 at 2:42 PM Alexandre TORGUE
> <alexandre.torgue@xxxxxxxxxxx> wrote:
> > Hi Dario
> >
> > On 6/7/23 08:31, Dario Binacchi wrote:
> > > Add pin configurations for using LTDC (LCD-tft Display Controller) on
> > > stm32f746-disco board.
> > >
> > > Signed-off-by: Dario Binacchi <dario.binacchi@xxxxxxxxxxxxxxxxxxxx>
> > > ---
> > >
> > > (no changes since v1)
> > >
> > >    arch/arm/boot/dts/stm32f7-pinctrl.dtsi | 35 ++++++++++++++++++++++++++
> > >    1 file changed, 35 insertions(+)
> > >
> > > diff --git a/arch/arm/boot/dts/stm32f7-pinctrl.dtsi b/arch/arm/boot/dts/stm32f7-pinctrl.dtsi
> > > index 9f65403295ca..f3f90b9bcd61 100644
> > > --- a/arch/arm/boot/dts/stm32f7-pinctrl.dtsi
> > > +++ b/arch/arm/boot/dts/stm32f7-pinctrl.dtsi
> > > @@ -365,6 +365,41 @@ pins2 {
> > >                                        bias-pull-up;
> > >                                };
> > >                        };
> > > +
> > > +
> > > +                     ltdc_pins_a: ltdc-pins-a-0 {
> >
> >    ltdc-pins-a-0 -->  ltdc-pins-0 is a bit cleaner. I know that I have to
> > fix sdio pins nodes in this file to keep the same spirit for all group
> > names.
>
> I have looked at the file arch/arm/boot/dts/stm32f7-pinctrl.dtsi, and
> based on the following nodes:
> usart1_pins_a: usart1-0
> i2c1_pins_b: i2c1-0
> can1_pins_a: can1-0
>
> I have decided to rename ltdc-pins-a-0 to ltdc-0.
>
> I hope you agree.

Yes! perfect.

Alex

> Thanks and regards,
>
> Dario
>
> > If there is no V3 I wil do it directly when I'll apply DT patches if you
> > agree.
> >
> > Alex
> >
> >
> > > +                             pins {
> > > +                                     pinmux = <STM32_PINMUX('E', 4, AF14)>, /* LCD_B0 */
> > > +                                              <STM32_PINMUX('G',12, AF9)>,  /* LCD_B4 */
> > > +                                              <STM32_PINMUX('I', 9, AF14)>, /* LCD_VSYNC */
> > > +                                              <STM32_PINMUX('I',10, AF14)>, /* LCD_HSYNC */
> > > +                                              <STM32_PINMUX('I',14, AF14)>, /* LCD_CLK */
> > > +                                              <STM32_PINMUX('I',15, AF14)>, /* LCD_R0 */
> > > +                                              <STM32_PINMUX('J', 0, AF14)>, /* LCD_R1 */
> > > +                                              <STM32_PINMUX('J', 1, AF14)>, /* LCD_R2 */
> > > +                                              <STM32_PINMUX('J', 2, AF14)>, /* LCD_R3 */
> > > +                                              <STM32_PINMUX('J', 3, AF14)>, /* LCD_R4 */
> > > +                                              <STM32_PINMUX('J', 4, AF14)>, /* LCD_R5 */
> > > +                                              <STM32_PINMUX('J', 5, AF14)>, /* LCD_R6 */
> > > +                                              <STM32_PINMUX('J', 6, AF14)>, /* LCD_R7 */
> > > +                                              <STM32_PINMUX('J', 7, AF14)>, /* LCD_G0 */
> > > +                                              <STM32_PINMUX('J', 8, AF14)>, /* LCD_G1 */
> > > +                                              <STM32_PINMUX('J', 9, AF14)>, /* LCD_G2 */
> > > +                                              <STM32_PINMUX('J',10, AF14)>, /* LCD_G3 */
> > > +                                              <STM32_PINMUX('J',11, AF14)>, /* LCD_G4 */
> > > +                                              <STM32_PINMUX('J',13, AF14)>, /* LCD_B1 */
> > > +                                              <STM32_PINMUX('J',14, AF14)>, /* LCD_B2 */
> > > +                                              <STM32_PINMUX('J',15, AF14)>, /* LCD_B3 */
> > > +                                              <STM32_PINMUX('K', 0, AF14)>, /* LCD_G5 */
> > > +                                              <STM32_PINMUX('K', 1, AF14)>, /* LCD_G6 */
> > > +                                              <STM32_PINMUX('K', 2, AF14)>, /* LCD_G7 */
> > > +                                              <STM32_PINMUX('K', 4, AF14)>, /* LCD_B5 */
> > > +                                              <STM32_PINMUX('K', 5, AF14)>, /* LCD_B6 */
> > > +                                              <STM32_PINMUX('K', 6, AF14)>, /* LCD_B7 */
> > > +                                              <STM32_PINMUX('K', 7, AF14)>; /* LCD_DE */
> > > +                                     slew-rate = <2>;
> > > +                             };
> > > +                     };
> > >                };
> > >        };
> > >    };