On Mon, 22 May 2023, Tetsuo Handa <penguin-kernel@xxxxxxxxxxxxxxxxxxx> wrote: > Like commit c4f135d643823a86 ("workqueue: Wrap flush_workqueue() using a > macro") says, flush_scheduled_work() is dangerous and will be forbidden. > > i915 became the last flush_scheduled_work() user, but developers cannot > find time for auditing which work items does this flush_scheduled_work() > need to wait. > > Therefore, for now let's start with blind/mechanical conversion within > the whole drivers/gpu/drm/i915/ directory, based on an assumption that > i915 does not need to wait for work items outside of this directory. I'll note also here that I've just pushed Luca's series [1] to switch i915 to internal device specific workqueues, for the same effect as this one. Thanks, Jani. [1] https://patchwork.freedesktop.org/series/118947/ -- Jani Nikula, Intel Open Source Graphics Center