On 8.06.2023 22:58, Rob Herring wrote: > On Tue, May 30, 2023 at 03:35:09PM +0200, Konrad Dybcio wrote: >> >> >> On 30.05.2023 14:26, Krzysztof Kozlowski wrote: >>> On Mon, 29 May 2023 15:52:20 +0200, Konrad Dybcio wrote: >>>> The "GMU Wrapper" is Qualcomm's name for "let's treat the GPU blocks >>>> we'd normally assign to the GMU as if they were a part of the GMU, even >>>> though they are not". It's a (good) software representation of the GMU_CX >>>> and GMU_GX register spaces within the GPUSS that helps us programatically >>>> treat these de-facto GMU-less parts in a way that's very similar to their >>>> GMU-equipped cousins, massively saving up on code duplication. >>>> >>>> The "wrapper" register space was specifically designed to mimic the layout >>>> of a real GMU, though it rather obviously does not have the M3 core et al. >>>> >>>> GMU wrapper-equipped A6xx GPUs require clocks and clock-names to be >>>> specified under the GPU node, just like their older cousins. Account >>>> for that. >>>> >>>> Signed-off-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxx> >>>> --- >>>> .../devicetree/bindings/display/msm/gpu.yaml | 61 ++++++++++++++++++---- >>>> 1 file changed, 52 insertions(+), 9 deletions(-) >>>> >>> >>> Running 'make dtbs_check' with the schema in this patch gives the >>> following warnings. Consider if they are expected or the schema is >>> incorrect. These may not be new warnings. >> I think it'd be beneficial if the bot diffed the output of checks pre- >> and post- patch. > > Fix all the warnings and it will. ;) Nice one :P Care to donate h/w to run the build > twice every time? Personally that might be a bit difficult, but I'm pretty sure KernelCI farms don't run at full throttle 24/7, perpaps some of their capacity could be borrowed? > > Really what I care about on these is when I keep getting changes to a > schema and the list of warnings remains long and not getting fixed. > > This case was less than useful with just the oneOf warning. Ack Konrad > > Rob
