Hi,
On Wed, Jun 7, 2023 at 6:25 PM Su Hui <suhui@xxxxxxxxxxxx> wrote:
>
> Smatch error:buffer overflow 'ti_sn_bridge_refclk_lut' 5 <= 5.
>
> Fixes: cea86c5bb442 ("drm/bridge: ti-sn65dsi86: Implement the pwm_chip")
> Signed-off-by: Su Hui <suhui@xxxxxxxxxxxx>
> ---
> drivers/gpu/drm/bridge/ti-sn65dsi86.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/gpu/drm/bridge/ti-sn65dsi86.c b/drivers/gpu/drm/bridge/ti-sn65dsi86.c
> index 7a748785c545..4676cf2900df 100644
> --- a/drivers/gpu/drm/bridge/ti-sn65dsi86.c
> +++ b/drivers/gpu/drm/bridge/ti-sn65dsi86.c
> @@ -298,6 +298,10 @@ static void ti_sn_bridge_set_refclk_freq(struct ti_sn65dsi86 *pdata)
> if (refclk_lut[i] == refclk_rate)
> break;
>
> + /* avoid buffer overflow and "1" is the default rate in the datasheet. */
> + if (i >= refclk_lut_size)
> + i = 1;
> +
Looks great now, thanks!
Reviewed-by: Douglas Anderson <dianders@xxxxxxxxxxxx>
Unless someone beats me to it or objects, I'll plan to commit this to
drm-misc-fixes early next week.
-Doug
