On 08/06/2023 11:36, Andi Shyti wrote: > Hi Jianzheng, > > On Thu, Jun 08, 2023 at 11:34:46AM +0800, Wang Jianzheng wrote: >> Remove unneeded variable and directly return 0. >> >> Signed-off-by: Wang Jianzheng <wangjianzheng@xxxxxxxx> >> --- >> drivers/gpu/drm/panel/panel-samsung-s6d7aa0.c | 3 +-- >> 1 file changed, 1 insertion(+), 2 deletions(-) >> >> diff --git a/drivers/gpu/drm/panel/panel-samsung-s6d7aa0.c b/drivers/gpu/drm/panel/panel-samsung-s6d7aa0.c >> index 102e1fc7ee38..fec0d014fd0e 100644 >> --- a/drivers/gpu/drm/panel/panel-samsung-s6d7aa0.c >> +++ b/drivers/gpu/drm/panel/panel-samsung-s6d7aa0.c >> @@ -66,7 +66,6 @@ static void s6d7aa0_reset(struct s6d7aa0 *ctx) >> static int s6d7aa0_lock(struct s6d7aa0 *ctx, bool lock) > > actually this function can completely made void. It can't be made void, as the mipi_dsi_dcs_write_seq() macro calls return with an int[1]. Best regards Artur [1] https://github.com/torvalds/linux/blob/v6.4-rc5/include/drm/drm_mipi_dsi.h#L319-L337
