On Tue, Jun 06, 2023 at 10:23:46PM +0200, Marijn Suijten wrote: > > @@ -359,8 +359,8 @@ static void dpu_encoder_phys_cmd_tearcheck_config( > > * frequency divided by the no. of rows (lines) in the LCDpanel. > > */ > > vsync_hz = dpu_kms_get_clk_rate(dpu_kms, "vsync"); > > - if (vsync_hz <= 0) { > > - DPU_DEBUG_CMDENC(cmd_enc, "invalid - vsync_hz %u\n", > > + if (!vsync_hz) { > > + DPU_DEBUG_CMDENC(cmd_enc, "invalid - vsync_hz %lu\n", > > vsync_hz); > > Nit: no need to print the value here, you know it's zero. Could be > clarified to just "no vsync clock". > Yeah. That's obviously not useful. Sorry, I will resend. regards, dan carpenter