On 07/06/2023 11:29, Paulo Pavacic wrote: > Hello Krzysztof, > > uto, 6. lip 2023. u 16:43 Krzysztof Kozlowski > <krzysztof.kozlowski@xxxxxxxxxx> napisao je: >> >> On 06/06/2023 16:07, Paulo Pavacic wrote: >>> Added fannal to vendor-prefixes and dt bindings for Fannal C3004. >>> Fannal C3004 is a 480x800 MIPI DSI Panel which requires >>> DCS initialization sequences with certain delays between certain >>> commands. >>> >>> Signed-off-by: Paulo Pavacic <pavacic.p@xxxxxxxxx> >>> --- >>> v4 changelog: >>> - add spaces between properties >> >> ??? > > Added empty lines between properties in yml file > >> >> I pointed out last incorrect versioning. This is v3, not v4. Or is it v4? > > It is v4 of the patch but v3 of the patchset. I wasn't sure whether > somebody would complain if I were to name [patch 2/3] in a patch set > with different version. I will try to edit changelog to match patchset > version. Please maintain consistent versioning. There is only one version - that's the version you are sending. > >> >> What about my tag? >> > > I have changed in MAINTAINERS file from "+C: > matrix:r/mipi-dsi-bringup:matrix.org" to " +C: > matrix:r/linux-drm:matrix.org". So I wasn't sure whether to add it. > I will add it in future version of the patch. Keep the tags you received. > >> What about my comment? >> > > I thought you wanted me to have more generalized MAINTAINERS community > URI that's why I have changed it to linux-drm. I will remove community > URI in future version of the patch. The chat should be in subsystem entry, not in individual drivers. People will not hop between 100 IRC rooms to figure out discussion. Just like we have only one mailing list dedicated to given topic. Best regards, Krzysztof
