On Tuesday, June 6th, 2023 at 22:25, Harry Wentland <harry.wentland@xxxxxxx> wrote: > + if (supported_colorspaces != 0 && (colorspaces & BIT(i)) == 0) This patch actually also introduces a change in behavior: passing no colorspace will make the function advertise all colorspaces. I have a hard time understanding how this can be useful: we want to either advertise all DP colorspaces, or all HDMI colorspaces, but not both? One way to fix this would be to handle the "zero means everything" behavior in the specific DP/HDMI callers. But I wonder, is it really worth the magic if we can expose a simple const variable with all DP/HDMI colorspaces?