> I think the return value isn't checked at all, so you could > simply return below "-ENODEV" for all cases (instead of "return ret"). > Then you don't need the e_nodev label and can simplify the flow. I noticed that the software evolution was continued with an other change variant. fbdev: imsttfb: Release framebuffer and dealloc cmap on error path https://lore.kernel.org/linux-fbdev/20230527093016.486521-1-deller@xxxxxx/ https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/drivers/video/fbdev/imsttfb.c?h=v6.4-rc5&id=5cf9a090a39c97f4506b7b53739d469b1c05a7e9 Regards, Markus
