On Tue, 06 Jun 2023 20:27:06 +0530, Laurent Pinchart wrote:
> Hi Siddh,
>
> Thank you for the patch.
Anytime :)
> > if (!ctx_entry) {
> > - DRM_DEBUG("out of memory\n");
> > + drm_dbg_core(dev, "out of memory\n");
>
> This message could also be dropped.
Okay.
> > - DRM_DEBUG("\n");
> > + drm_dbg_core(dev, "\n");
>
> This message seems of dubious value :-) Maybe you could drop it in a
> patch on top of this series ?
Okay.
> > - DRM_DEBUG("\n");
> > + drm_dbg_core(NULL, "\n");
>
> This is even worse :-) The next two messages are also fairly useless,
> they should be expanded, or dropped.
Okay.
> > - DRM_DEBUG("\n");
> > + drm_dbg_core(dev, "\n");
>
> Ditto.
Okay.
> > + drm_dbg_core(dev, "\n");
> > +
>
> Same, and the two messages below too.
Okay.
> > - DRM_DEBUG("\n");
> > + drm_dbg_core(dev, "\n");
>
> Here too.
Okay.
> With the commit subject fixed,
>
> Reviewed-by: Laurent Pinchart laurent.pinchart+renesas@xxxxxxxxxxxxxxxx>
Thanks,
Siddh
