On Tue, Jun 06, 2023 at 10:59:14PM +0530, Siddh Raman Pant wrote: > On Tue, 06 Jun 2023 20:35:45 +0530, Laurent Pinchart wrote: > > This is a nice series, thank you for working on that. > > > > Now that the deprecated macros are used in drivers only, would it make > > sense to move them to a drm_print_deprecated.h header, to make sure no > > new driver uses them ? > > Sure, but then should that header be included wherever drm_print.h is > included with a find and replace, to avoid breakage? The idea would be to include the drm_print_deprecated.h header in drivers that still use the deprecated macros. > Not every file can be seen at a case-by-case basis or by coccinelle > as far as I understand its usage. Consider the following: > > DRM_INFO is used on line 210 of amd/amdgpu/amdgpu_acpi.c, but the > file does not even include drm_print.h directly. It includes the > amdgpu.h header, which includes the amdgpu_ring.h header, which > finally has the "#include <drm/drm_print.h>" line. > > If a simple find and replace has to be done, then that can be added > at the end of the series. Maybe a simple grep for the deprecated macros would be enough to identify all the files that still use them ? -- Regards, Laurent Pinchart
