[ +CC: Thorsten and regzbot so they can help with tracking this regression ] #regzbot introduced: v6.3..v6.4-rc1 On Tue, May 23, 2023 at 05:16:46PM +0200, Johan Hovold wrote: > This reverts commit 1844e680d56bb0c4e0489138f2b7ba2dc1c988e3. > > PSR support clearly is not ready for mainline and specifically breaks > virtual terminals which are no longer updated when PSR is enabled (e.g. > no keyboard input is echoed, no cursor blink). > > Disable PSR support for now by reverting commit 1844e680d56b > ("drm/msm/dp: set self refresh aware based on PSR support"). > > Cc: Vinod Polimera <quic_vpolimer@xxxxxxxxxxx> > Cc: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx> > Signed-off-by: Johan Hovold <johan+linaro@xxxxxxxxxx> > --- > > Bjorn reported that PSR support broke virtual terminals two months ago, > but this is still broken in 6.4-rc3: > > https://lore.kernel.org/lkml/20230326162723.3lo6pnsfdwzsvbhj@ripper/ > > despite the following series that claimed to address this: > > https://lore.kernel.org/lkml/1680271114-1534-1-git-send-email-quic_vpolimer@xxxxxxxxxxx > > Let's revert until this has been fixed properly. Virtual terminals are still broken with 6.4-rc5 on the Lenovo ThinkPad X13s two weeks after I reported this, and there has been no indication of any progress in the other related thread: https://lore.kernel.org/lkml/ZHYPHnWoDbXB-fqe@xxxxxxxxxxxxxxxxxxxx Seems like it is time to merge this revert to get this sorted. Rob, Abhinav, Dmitry, can either of you merge this one and get it into 6.4-rc6? Johan