On Sun, Jun 4, 2023 at 3:57 PM Masahiro Yamada <masahiroy@xxxxxxxxxx> wrote: > With CONFIG_DRM_IMX8QM_LDB=m and CONFIG_DRM_IMX8QXP_LDB=y (or vice > versa), imx-ldb-helper.o is linked to a module and also to vmlinux > even though the expected CFLAGS are different between builtins and > modules. > > This is the same situation as fixed by commit 637a642f5ca5 ("zstd: > Fixing mixed module-builtin objects"). > > Split imx-ldb-helper.c into a separate module. > > Signed-off-by: Masahiro Yamada <masahiroy@xxxxxxxxxx> > --- > > Changes in v2: > - Add a separate module instead of making the functions static inline > > drivers/gpu/drm/bridge/imx/Kconfig | 5 +++++ > drivers/gpu/drm/bridge/imx/Makefile | 5 +++-- > drivers/gpu/drm/bridge/imx/imx-ldb-helper.c | 20 ++++++++++++++++++++ > 3 files changed, 28 insertions(+), 2 deletions(-) [...] Reviewed-by: Liu Ying <victor.liu@xxxxxxx>