On 5/31/23 12:31, Krzysztof Kozlowski wrote:
On 31/05/2023 21:29, Florian Fainelli wrote:+ required: + - reg + - brcm,channel + + additionalProperties: false + +patternProperties: + "^mdio@[0-9a-f]+$":Isn't mdio a property of each ethernet port? Existing users (e.g.bcmgenet, owl-emac, switches) do it that way...They are sub-nodes of the larger Ethernet controller block, hence the property here.This is the Ethernet controller. They are subnodes here, so what do you mean by that? They are part of some other block?
The block is not just an Ethernet controller it has other functions, which is why we went with a top-level node with a 'ranges' property. One of those functions are the MDIO bus controllers. The examples makes it reasonably clear.
Otherwise how do you define relation-ship? Can one mdio fit multiple ports?The relationship is established between Ethernet ports and children nodes of the MDIO controller, such as switches or Ethernet PHYs using 'phy-handle' for instance. And yes, a single/common MDIO controller could be serving multiple Ethernet ports.We do not talk about generic case, but your device.
The generic case is true here as well. We so happen to have a 1:1 mapping between the MDIO controller, PHY, and Ethernet port, in this particular example.
-- Florian
Attachment:
smime.p7s
Description: S/MIME Cryptographic Signature
