Hi, On Tue, May 30, 2023 at 12:42 AM Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx> wrote: > > The .remove() callback for a platform driver returns an int which makes > many driver authors wrongly assume it's possible to do error handling by > returning an error code. However the value returned is (mostly) ignored > and this typically results in resource leaks. To improve here there is a > quest to make the remove callback return void. In the first step of this > quest all drivers are converted to .remove_new() which already returns > void. > > panel_edp_remove() always returned zero, so convert it to return void > without any loss and then just drop the return from > panel_edp_platform_remove(). > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx> > --- > drivers/gpu/drm/panel/panel-edp.c | 10 ++++------ > 1 file changed, 4 insertions(+), 6 deletions(-) Looks great, thanks. Reviewed-by: Douglas Anderson <dianders@xxxxxxxxxxxx> I see no reason for a delay in applying, so I pushed to drm-misc-next: 72a597aed1d9 drm/panel-edp: Convert to platform remove callback returning void
