Re: [PATCH 2/3] drm/i915/guc: Update log for unsolicited CTB response

[John Harrison <john.c.harrison@xxxxxxxxx>]

On 5/26/2023 16:55, John.C.Harrison@xxxxxxxxx wrote:
> From: Michal Wajdeczko <michal.wajdeczko@xxxxxxxxx>
>
> Instead of printing message fence twice, include HXG header of the
> unexpected message and its len.
>
> Signed-off-by: Michal Wajdeczko <michal.wajdeczko@xxxxxxxxx>
> Signed-off-by: John Harrison <John.C.Harrison@xxxxxxxxx>
Reviewed-by: John Harrison <John.C.Harrison@xxxxxxxxx>

> ---
>   drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c | 5 ++---
>   1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c b/drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c
> index af52ed4ffc7fb..3a71bb582089e 100644
> --- a/drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c
> +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c
> @@ -994,9 +994,8 @@ static int ct_handle_response(struct intel_guc_ct *ct, struct ct_incoming_msg *r
>   		break;
>   	}
>   	if (!found) {
> -		CT_ERROR(ct, "Unsolicited response (fence %u)\n", fence);
> -		CT_ERROR(ct, "Could not find fence=%u, last_fence=%u\n", fence,
> -			 ct->requests.last_fence);
> +		CT_ERROR(ct, "Unsolicited response message: len %u, data %#x (fence %u, last %u)\n",
> +			 len, hxg[0], fence, ct->requests.last_fence);
>   		list_for_each_entry(req, &ct->requests.pending, link)
>   			CT_ERROR(ct, "request %u awaits response\n",
>   				 req->fence);