Hi,
Previously, I don't realize some arch doesn't enable CONFIG_PCI by default.
This problem only happens on the arch which CONFIG_PCI isn't being enabled.
This problem also caused by the fact that pci_clear_master don't have a
dummy implement.
I have create a patch to fix that, see [1].
This problem is easy to fix, with some #ifdef and #endif definition guard,
make the PCI driver support don't get compiled on the architecture which
don't have CONFIG_PCI enable. Originally, I want it always built-in.
Should I fix this problem at driver side and respin this patch?
[1]
https://patchwork.kernel.org/project/linux-pci/patch/20230530101655.2275731-1-suijingfeng@xxxxxxxxxxx/
On 2023/5/30 17:00, kernel test robot wrote:
Hi Sui,
kernel test robot noticed the following build errors:
[auto build test ERROR on drm-misc/drm-misc-next]
[also build test ERROR on drm/drm-next drm-intel/for-linux-next drm-intel/for-linux-next-fixes drm-tip/drm-tip linus/master v6.4-rc4 next-20230530]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Sui-Jingfeng/drm-etnaviv-add-a-dedicated-function-to-register-an-irq-handler/20230530-012547
base: git://anongit.freedesktop.org/drm/drm-misc drm-misc-next
patch link: https://lore.kernel.org/r/20230529172452.2148819-6-suijingfeng%40loongson.cn
patch subject: [PATCH v5 5/6] drm/etnaviv: expand driver support for the PCI devices
config: m68k-allmodconfig (https://download.01.org/0day-ci/archive/20230530/202305301659.4guSLavL-lkp@xxxxxxxxx/config)
compiler: m68k-linux-gcc (GCC) 12.3.0
reproduce (this is a W=1 build):
mkdir -p ~/bin
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/1d05a5fa048dd4b2a934ffbb07c330ddd9279287
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Sui-Jingfeng/drm-etnaviv-add-a-dedicated-function-to-register-an-irq-handler/20230530-012547
git checkout 1d05a5fa048dd4b2a934ffbb07c330ddd9279287
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.3.0 ~/bin/make.cross W=1 O=build_dir ARCH=m68k olddefconfig
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.3.0 ~/bin/make.cross W=1 O=build_dir ARCH=m68k SHELL=/bin/bash drivers/gpu/drm/etnaviv/
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202305301659.4guSLavL-lkp@xxxxxxxxx/
All errors (new ones prefixed by >>):
drivers/gpu/drm/etnaviv/etnaviv_pci_drv.c: In function 'etnaviv_gpu_pci_fini':
drivers/gpu/drm/etnaviv/etnaviv_pci_drv.c:32:9: error: implicit declaration of function 'pci_clear_master'; did you mean 'pci_set_master'? [-Werror=implicit-function-declaration]
32 | pci_clear_master(pdev);
| ^~~~~~~~~~~~~~~~
| pci_set_master
cc1: some warnings being treated as errors
vim +32 drivers/gpu/drm/etnaviv/etnaviv_pci_drv.c
27
28 static void etnaviv_gpu_pci_fini(struct etnaviv_gpu *gpu, bool component)
29 {
30 struct pci_dev *pdev = to_pci_dev(gpu->dev);
31
> 32 pci_clear_master(pdev);
33
34 dev_dbg(gpu->dev, "component is %s\n",
35 component ? "enabled" : "disabled");
36 }
37
