Re: [PATCH] drm/ttm: Remove redundant code in ttm_tt_init_fields

[Christian König <christian.koenig@xxxxxxx>]

Am 29.05.23 um 11:28 schrieb Ma Jun:
> Remove redundant assignment code for ttm->caching

The explanation is missing why this is redundant, e.g. something like 
"this is overwritten just a few lines later"..

Apart from that looks good to me,
Christian.,

> Signed-off-by: Ma Jun <Jun.Ma2@xxxxxxx>
> ---
>   drivers/gpu/drm/ttm/ttm_tt.c | 1 -
>   1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/ttm/ttm_tt.c b/drivers/gpu/drm/ttm/ttm_tt.c
> index 02b812dacc5d..45a44544b656 100644
> --- a/drivers/gpu/drm/ttm/ttm_tt.c
> +++ b/drivers/gpu/drm/ttm/ttm_tt.c
> @@ -143,7 +143,6 @@ static void ttm_tt_init_fields(struct ttm_tt *ttm,
>   			       unsigned long extra_pages)
>   {
>   	ttm->num_pages = (PAGE_ALIGN(bo->base.size) >> PAGE_SHIFT) + extra_pages;
> -	ttm->caching = ttm_cached;
>   	ttm->page_flags = page_flags;
>   	ttm->dma_address = NULL;
>   	ttm->swap_storage = NULL;