Sounds weird to have a platform restriction on uAPI though. UMD not using this extension is not a problem, is it?
From: Tvrtko Ursulin <tvrtko.ursulin@xxxxxxxxxxxxxxx>
Sent: Thursday, May 25, 2023 1:33 AM
To: Yang, Fei <fei.yang@xxxxxxxxx>; intel-gfx@xxxxxxxxxxxxxxxxxxxxx <intel-gfx@xxxxxxxxxxxxxxxxxxxxx> Cc: dri-devel@xxxxxxxxxxxxxxxxxxxxx <dri-devel@xxxxxxxxxxxxxxxxxxxxx>; Vivi, Rodrigo <rodrigo.vivi@xxxxxxxxx> Subject: Re: [Intel-gfx] [PATCH v12 0/1] drm/i915: Allow user to set cache at BO creation On 24/05/2023 21:02, fei.yang@xxxxxxxxx wrote: > From: Fei Yang <fei.yang@xxxxxxxxx> > > This series introduce a new extension for GEM_CREATE, > 1. end support for set caching ioctl [PATCH 1/2] > 2. add set_pat extension for gem_create [PATCH 2/2] > > v2: drop one patch that was merged separately > commit 341ad0e8e254 ("drm/i915/mtl: Add PTE encode function") > v3: rebased on https://patchwork.freedesktop.org/series/117082/ > v4: fix missing unlock introduced in v3, and > solve a rebase conflict > v5: replace obj->cache_level with pat_set_by_user, > fix i915_cache_level_str() for legacy platforms. > v6: rebased on https://patchwork.freedesktop.org/series/117480/ > v7: rebased on https://patchwork.freedesktop.org/series/117528/ > v8: dropped the two dependent patches that has been merged > separately. Add IGT link and Tested-by (MESA). > v9: addressing comments (Andi) > v10: acked-by and tested-by MESA > v11: drop "end support for set caching ioctl" (merged) > remove tools/include/uapi/drm/i915_drm.h > v12: drop Bspec reference in comment. add to commit message instead > > Fei Yang (1): > drm/i915: Allow user to set cache at BO creation > > drivers/gpu/drm/i915/gem/i915_gem_create.c | 36 +++++++++++++++++++ > drivers/gpu/drm/i915/gem/i915_gem_object.c | 6 ++++ > include/uapi/drm/i915_drm.h | 41 ++++++++++++++++++++++ > 3 files changed, 83 insertions(+) > Do you also have a Test-with: run against the new IGT somewhere? Regards, Tvrtko |