>> The value “-ENOMEM” was assigned to the variable “ret” >> at the beginning. >> Move this statement directly before the first ioremap() call. > > Please do not move such variables without real need. Is there a need to explain desirable effects better? > It makes backporting (of this and maybe follow-up patches) much more complicated I propose to reconsider such development concerns a bit more. https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/log/drivers/video/fbdev/imsttfb.c?h=v6.4-rc3 > and the compiler will optimize it anyway. How much do expectations fit to supported and documented software optimisations? Regards, Markus
