Re: [PATCH v2] accel/qaic: initialize ret variable to 0

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 5/17/2023 10:56 AM, Jeffrey Hugo wrote:
From: Tom Rix <trix@xxxxxxxxxx>

clang static analysis reports
drivers/accel/qaic/qaic_data.c:610:2: warning: Undefined or garbage
   value returned to caller [core.uninitialized.UndefReturn]
         return ret;
         ^~~~~~~~~~

 From a code analysis of the function, the ret variable is only set some
of the time but is always returned.  This suggests ret can return
uninitialized garbage. However BO allocation will ensure ret is always
set in reality.

Initialize ret to 0 to silence the warning.

Fixes: ff13be830333 ("accel/qaic: Add datapath")
Signed-off-by: Tom Rix <trix@xxxxxxxxxx>
[jhugo: Reword commit text]
Signed-off-by: Jeffrey Hugo <quic_jhugo@xxxxxxxxxxx>

Pushed to drm-misc-fixes



[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux